I’m a bit new to PowerShell and was wondering if there are any improvements I could make to the following script. Any suggestions for style, code, etc. are all welcome.
I’m not sure if there is a more efficient way of filtering the files by last modified date. I need to run it against 30 million files in batches of 500,000.
I’ve included an example of the UNC path that I use to produce the results file name in the $ tempArg variable based off of a folder name of the office location.
I’m currently running this script in a .bat file. Is there a better way of running this script concurrently?
PowerShell Script
$ filePathAttributes = "C:\Temp\*.*" #$ args[0] $ tempArg = "\server\state$ \office name\documents\*.*" #An example of the path format $ folder = ($ tempArg).Substring(1, ($ tempArg).Length - 4) $ parent = Split-Path $ folder $ office = Split-Path $ parent -Leaf $ office_format = $ office -replace '\W','-' $ filePathResults = "C:\Temp\Results_" + $ office_format + ".csv" $ linenumber = 1 Get-Childitem -recurse -Path $ filePathAttributes | ? {$ _.lastwritetime -gt '01-Jul-2018' -AND $ _.lastwritetime -lt '31-Mar-2019'} | ForEach-Object { $ fullName = $ _.FullName Get-Content $ fullName | Measure-Object -Line -Character -Word | Select-Object -ExcludeProperty Property @{ Name = 'FileID'; Expression={$ linenumber}}, @{ Name = 'ExtractTime'; Expression={ Get-Date -format "dd-MMM-yyyy HH:mm:ss.fff" }}, @{ Name = 'FullName'; Expression={ $ fullName }}, @{ Name = 'FilePath'; Expression={ [System.IO.Path]::GetDirectoryName($ fullName) }}, @{ Name = 'FileName'; Expression={ [System.IO.Path]::GetFileName($ fullName) }}, @{ Name = 'FileSize'; Expression={ (Get-Item $ fullName).length / 1024 }}, @{ Name = 'Attributes'; Expression={(Get-ItemProperty $ fullName).Attributes }}, @{ Name = 'LastWriteTime'; Expression={(Get-ItemProperty $ fullName).LastWriteTime }}, @{ Name = 'CreationTime'; Expression={(Get-ChildItem $ fullName).CreationTime }}, * ;$ linenumber ++ } | Export-Csv -NoTypeInformation -Path $ filePathResults Batch File Script
start powershell.exe C:\Temp\FileAttributes.ps1 "C:\Temp\*.*" start powershell.exe C:\Temp\FileAttributes.ps1 "C:\Temp1\*.*" start powershell.exe C:\Temp\FileAttributes.ps1 "C:\Temp2\*.*" Example of CSV file
